Fix DamlCIUpgradeVotePreflightTest #1076
Merged
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Tinguely <julien.tinguely@digitalasset.com>
| val dropDownAction = new Select(webDriver.findElement(By.id("display-actions"))) | ||
| dropDownAction.selectByValue("CRARC_SetConfig") | ||
|
|
||
| click on "action-change-dialog-proceed" |
Contributor
There was a problem hiding this comment.
And you are sure this exists every time we run this test?
Contributor
Author
There was a problem hiding this comment.
yes it's on devnet and testnet
martinflorian-da
approved these changes
Jun 11, 2025
Contributor
martinflorian-da
left a comment
martinflorian-da
left a comment
There was a problem hiding this comment.
Thanks for fixing! Let's watch the deploy_upgrade flow for this closely to confirm. (I'll cancel all the existing such workflows to get feedback more quickly.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/DACH-NY/cn-test-failures/issues/4505
tested the fix on a scratchnet
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines